Adds LocationGroup, TimeGroup enumeration to the Types class
ClosedPublic

Authored by atulsharma on Jul 7 2017, 6:09 PM.

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulsharma created this revision.Jul 7 2017, 6:09 PM
mart added inline comments.Jul 7 2017, 6:16 PM
src/groups.h
22 ↗(On Diff #16316)

I would prefer this file and Roles to get merged in a single Types class, so not too many empty qobjects are created

atulsharma updated this revision to Diff 16317.Jul 7 2017, 6:22 PM

Adds the Groups to qml type

atulsharma updated this revision to Diff 16319.Jul 7 2017, 6:38 PM

Adds the enumeration LocationGroup and TimeGroup to the Types class

atulsharma retitled this revision from Creates a common Groups class for LocationGroup, TimeGroup enumeration to Adds LocationGroup, TimeGroup enumeration to the Types class.Jul 7 2017, 6:39 PM
mart accepted this revision.Jul 7 2017, 6:43 PM
This revision is now accepted and ready to land.Jul 7 2017, 6:43 PM
This revision was automatically updated to reflect the committed changes.