A fix I did for the focus line being drawn outside item boundaries resulted in the item selection rectangle being "cut off" by the focus line. The selection rectangle is enough of an indication anyway.
- Group Reviewers
- R31:89b916039387: Don't draw focus line on selected list item
Focus line still shown when the item is not selected:
Especially noticeable in KInfoCenter where there's a tree list and only the label is underlined but not the icon, resulting in an uneven "cut".
From what I can tell the difference is negligible. qobject_cast goes through QMetaObject::cast which then calls inherits internally, so I'd say inherits is the better choice.
I didn't benchmark, though. I just followed what the rest of the code around it was doing (inherits)