When requesting from the cache, report all entries at bulk
ClosedPublic

Authored by apol on Jul 6 2017, 4:41 PM.

Details

Summary

No need to signal separate times. This gives the client the possibility to know
whether it should request for more entries or not. Otherwise it might request them
when they will be fetched anyway.

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jul 6 2017, 4:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 6 2017, 4:41 PM
leinir accepted this revision.Jul 7 2017, 8:06 AM

Hmm... i was thinking this could cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ). Nothing in the API suggests you might get more than the requested number when you ask for entries, but conversely nothing says you will potentially get less, and that happens on a regular basis, so... sure, why not :)

This revision is now accepted and ready to land.Jul 7 2017, 8:06 AM
apol closed this revision.Jul 7 2017, 3:33 PM