Also use m_currentRequest when checking for installed and updates
ClosedPublic

Authored by apol on Jul 3 2017, 8:56 PM.

Details

Summary

Otherwise if requestMoreData is called, we query the wrong request which
can be quite big if it happens before it's initialized

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jul 3 2017, 8:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 3 2017, 8:56 PM
leinir accepted this revision.Jul 4 2017, 8:29 AM

That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset before attempting to perform a search we will only search installed and updateable items. I don't think it is necessarily an enormous or insurmountable issue here, as far as i can tell the only code which currently uses these two functions is in KNS' own DownloadManagers (at least, lxr suggests as much), and if we ensure those two are fixed to reset the filter before launching a search, i think we're probably ok.

PS: These two functions also lack documentation, which shall need fixing (though not necessarily as a part of this D)

This revision is now accepted and ready to land.Jul 4 2017, 8:29 AM
leinir requested changes to this revision.Jul 4 2017, 8:30 AM

derp, not accepted, my bad...

This revision now requires changes to proceed.Jul 4 2017, 8:30 AM
apol updated this revision to Diff 16172.Jul 4 2017, 12:56 PM
apol edited edge metadata.

Improve documentation and consistency

apol updated this revision to Diff 16176.Jul 4 2017, 1:49 PM

Just document stuff

apol updated this revision to Diff 16178.Jul 4 2017, 1:58 PM

Fix doc

leinir accepted this revision.Jul 4 2017, 1:59 PM

Different approach, but yeah, telling people what'll actually happen works :)

This revision is now accepted and ready to land.Jul 4 2017, 1:59 PM