[platforms/x11] Fix incorrect screen edge approaching with switch desktop on window move

Authored by graesslin on Jul 2 2017, 11:46 AM.



There is a regression in WindowBasedEdge::soStopApproaching. Due to
only operate when the edge activates for pointer it is possible that
the cursor polling stays active. Explaining the situation:

  1. Activate switch desktop when moving window
  2. Start moving a window
  3. Move mouse into the approach geometry

-> doStartApproaching activates as we are moving a window

  1. stop moving window

-> doStopApproaching early exits as the position does not activate for

pointer any more - we are not moving a window

-> cursor polling is still connected and whenever mouse enters edge

approaching is started

The analysis shows that the check whether activates for pointer is wrong
in the case of stop approaching. If the edge started to approach, we also
need to stop approaching.

This change addresses the problem by turning the check into whether the
connection for cursor position update is set.

This is the third bug fix to the X11 screen edge handling after
introducing touch screen edges. This needs more manual testing by
everybody in the Plasma team who is still using X11.

BUG: 381849
FIXED-IN: 5.10.4

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 2 2017, 11:46 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 2 2017, 11:46 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jul 5 2017, 9:57 AM
This revision is now accepted and ready to land.Jul 5 2017, 9:57 AM
This revision was automatically updated to reflect the committed changes.