Makes the basics of ImageFolderModel works
ClosedPublic
Actions

Authored by atulsharma on Jun 30 2017, 8:24 PM.

Details

Reviewers

mart

Group Reviewers

Koko

Maniphest Tasks

T6421: make the ImageFolderModel work

Commits

Summary

"By Folder" navigation works now
Selection is also possible in "By Folder" view
On clicking or selecting a folder( which is distinguished by the AlbumDelegate) a new column is pushed to the pageStack
"By Folder" shows mixed folders and images that are navigable in hierarchy
SelectedRole from the ImageFolderModel is removed as the ImageFolderModel is wrapped inside that of the SortModel which already implements SelectedRole

Repository

R659 Koko Image Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

A little more better.
SelectedRole is removed from the ImageFolderModel, as now it is wrapped inside the SortModel

On the good path: it can be simplified by using the pagerow internal logic to create component s

qmlUiKirigami/AlbumDelegate.qml
117	Why is creating it manually? You can push directly a filename to the pagestack and will create the component for you

Removes the manual creation of AlbumView page component.

atulsharma marked an inline comment as done.Jul 1 2017, 7:20 PM

mart accepted this revision.Jul 3 2017, 8:04 AM

This revision is now accepted and ready to land.Jul 3 2017, 8:04 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			qmlUiKirigami/AlbumDelegate.qml (9 lines)
M			qmlUiKirigami/AlbumView.qml (14 lines)
M			qmlUiKirigami/main.qml (13 lines)
M			src/imagefoldermodel.h (3 lines)
M			src/imagefoldermodel.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16069	2672f18		Jun 30 2017, 8:24 PM	★	★
Diff 2	16077	2672f18	- A little more better.	Jul 1 2017, 9:14 AM	★	★
Diff 3	16090	2672f18	Removes the manual creation of AlbumView page component.	Jul 1 2017, 7:19 PM	★	★
Diff 4	16110	2672f18	R659:77329df1ff425f5f87727bef25114274a1b98f9a	Jul 3 2017, 8:15 AM	★	★