This adjusts the "configure" dialog in the same way as the "about" dialog I fixed in 2f66c0d11c68f13dd81d6a941d4ee95a63d4bdfe
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:e5e0e91daa52: [CurrentContainmentActionsModel] Allow making the action about dialog modal
Changed the code in ConfigurationContainmentAction to pass this (ie. the button you clicked) along and then the window was modal to the config dialog, no exec involved.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I would expect either:
if (ctx)
else {
// do what the old code did
}
or to be changing a bunch of QML code somewhere.
Comment Actions
// do what the old code did
"WindowModal" without a window makes it applicationmodal which is bad.
or to be changing a bunch of QML code somewhere.
Yes, I will change plasma-desktop ConfigurationContainmentActions accordingly.