[CurrentContainmentActionsModel] Allow making the action about dialog modal
ClosedPublic

Authored by broulik on Jun 30 2017, 8:16 AM.

Details

Summary

This adjusts the "configure" dialog in the same way as the "about" dialog I fixed in 2f66c0d11c68f13dd81d6a941d4ee95a63d4bdfe

Test Plan

Changed the code in ConfigurationContainmentAction to pass this (ie. the button you clicked) along and then the window was modal to the config dialog, no exec involved.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 30 2017, 8:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2017, 8:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I would expect either:

if (ctx)
else {

// do what the old code did

}

or to be changing a bunch of QML code somewhere.

// do what the old code did

"WindowModal" without a window makes it applicationmodal which is bad.

or to be changing a bunch of QML code somewhere.

Yes, I will change plasma-desktop ConfigurationContainmentActions accordingly.

davidedmundson accepted this revision.Jul 10 2017, 11:40 PM
This revision is now accepted and ready to land.Jul 10 2017, 11:40 PM
This revision was automatically updated to reflect the committed changes.