Restore active client after ending showing desktop
ClosedPublic

Authored by graesslin on Jun 28 2017, 3:24 PM.

Details

Summary

Showing desktop requests focus on the desktop window. This means the
active window is reset. When ending showing desktop the state was not
restored.

This change addresses this problem by requesting focus to the best
window.

BUG: 375993
FIXED-IN: 5.10.4

Test Plan

New autotest and manual testing

Diff Detail

Repository
R108 KWin
Branch
showing-desktop-active-5.10
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Jun 28 2017, 3:24 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 28 2017, 3:24 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
broulik added inline comments.
autotests/integration/showing_desktop_test.cpp
125

Is this intended?

broulik accepted this revision.Jun 28 2017, 3:36 PM
This revision is now accepted and ready to land.Jun 28 2017, 3:36 PM
graesslin updated this revision to Diff 15955.Jun 28 2017, 4:05 PM

Remove expect fail from testing

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJun 28 2017, 4:05 PM

Still there?

Still there?

sorry, but what do you mean?

FYI, I noticed that I did forget to remove the expect fail prior to reading your comment (you were faster and there is no mobile in Doppelstockwagen)

graesslin updated this revision to Diff 15964.Jun 28 2017, 7:48 PM

I'm too stupid for arc (or git), no really removed

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJun 28 2017, 7:48 PM
broulik accepted this revision.Jun 28 2017, 8:01 PM
This revision was automatically updated to reflect the committed changes.