Currently methods which have multiple overrides in the inheritance
chain are also displayed as often. Filtering these duplicates out
based on the signature improves the situation as a first step.
Details
Details
- Reviewers
mwolff - Group Reviewers
KDevelop - Commits
- R32:fcba0ad8ae38: Avoid duplicates in virtual overrides code completion proposals
E.g. QWidget subclasses have lots of methods repeated, with this
patch no longer.
Extended unit test failed before, no longer fails with patch.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Branch
- noduplicatesincodecompletion
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
- update to latest master
- respect methods being parsed with order from base class to sub class
Comment Actions
After:
Each virtual method only listed once, and no method wrongly shown inherited as still pure virtual
Examples for virtual override completion proposals by example of being triggered inside OktetaMainWindow class declaration, line
https://cgit.kde.org/okteta.git/tree/program/mainwindow.h#n47
Before:
Listing of pure virtual methods which though have been already overwritten in base classes of OktetaMainWindow, multiple listing of methods which got overridden multiple times in the inheritance chain
After:
Each virtual method only listed once, and no method wrongly shown inherited as still pure virtual
Comment Actions
Thanks for review!
| languages/clang/tests/test_codecompletion.cpp | ||
|---|---|---|
| 564 ↗ | (On Diff #15960) | Yes. Copy-paste of same error already in "deep" data above, will fix as separate commit. |