[platforms/x11] Use a GlxContextAttributeBuilder
ClosedPublic
Actions

Authored by graesslin on Jun 27 2017, 7:10 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:f88c322a3b83: [platforms/x11] Use a GlxContextAttributeBuilder

Summary

Based on the work of 3f4995fb9b4fd753a304ea65020bbafdd174936b this change
introduces a GlxContextAttributeBuilder to make the requesting of context
attributes cleaner, more verbose and less error prone copy and paste.

Test Plan

Switched between Core and legacy and verified the output;
extended auto test

Diff Detail

Repository

R108 KWin

Branch

glx-context-attribute-builder

Lint

No Linters Available

Unit

No Unit Test Coverage

graesslin created this revision.Jun 27 2017, 7:10 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 27 2017, 7:10 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin mentioned this in D6565: Query supported OpenGL core profile version on X11, GLX.Jul 8 2017, 12:56 PM

Rebased to master

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJul 17 2017, 3:44 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

ping

davidedmundson accepted this revision.Aug 18 2017, 12:22 AM

This revision is now accepted and ready to land.Aug 18 2017, 12:22 AM

Closed by commit R108:f88c322a3b83: [platforms/x11] Use a GlxContextAttributeBuilder (authored by graesslin). · Explain WhyAug 19 2017, 9:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		abstract_opengl_context_attribute_builder.h (9 lines)
M		autotests/CMakeLists.txt (11 lines)
M		autotests/opengl_context_attribute_builder_test.cpp (92 lines)
M		plugins/platforms/x11/standalone/CMakeLists.txt (2 lines)
A	M	plugins/platforms/x11/standalone/glx_context_attribute_builder.h (32 lines)
A	M	plugins/platforms/x11/standalone/glx_context_attribute_builder.cpp (53 lines)
M		plugins/platforms/x11/standalone/glxbackend.cpp (99 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15930	9600d13		Jun 27 2017, 7:10 PM	★	★
Diff 2	16830	73fa7b2	Rebased to master	Jul 17 2017, 3:44 PM	★	★
Diff 3	18382	36a3189	R108:f88c322a3b8388d58a3c4f63fd654198600d151e	Aug 19 2017, 9:34 AM	★	★