Differential D6408

libzip: preserve permissions when extracting files
ClosedPublic
Actions

Authored by elvisangelaccio on Jun 27 2017, 2:04 PM.

Details

Reviewers
rthomsen
Group Reviewers
Ark
Commits
R36:d3a7d7bb5fd9: libzip: preserve permissions when extracting files
Summary

The zip format reserves the 2 leftmost bytes of the extended file
attribute field (32 bits) for the UNIX permissions.
If the zip archive was crated with such metadata, we can just use the
libzip api to retrieve the extended file attribute and extract the
mode_t value from it.

BUG: 381499
FIXED-IN: 17.07.80

Test Plan

This fixes the 2 failing libzip test cases in ExtractTest::testPreservePermissions().

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Ark. · View Herald TranscriptJun 27 2017, 2:04 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
Closed by commit R36:d3a7d7bb5fd9: libzip: preserve permissions when extracting files (authored by elvisangelaccio). · Explain WhyJun 29 2017, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16018

View Options

plugins/libzipplugin/CMakeLists.txt

Loading...
View Options

plugins/libzipplugin/libzipplugin.cpp

Loading...