The structure was only freed in case the XTest method was chosen.
But it should always be freed of course (as long as it isn't NULL).
Use a QScopedPointer instead to free it automatically when it goes out of scope and to be more consistent with the rest of the code.
Builds, old-style system tray icons are still displayed here.
| Lint Skipped |
| Unit Tests Skipped |
Urgh, how did I not catch that last review.
Might be better to just swap with:
QScopedPointer<xcb_whatever_reply_t, QScopedPointerPodDeleter> = xcb_get_window_attrib
which we do for the other replies