Don't use plasma theme icons for application icons
ClosedPublic

Authored by broulik on Jun 26 2017, 10:00 AM.

Details

Test Plan

VLC has a Plasma icon now and we get a mix of apps and plasma icons. We typically don't use plasma theme for app-heavy things like task manager, launcher, etc

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 26 2017, 10:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 26 2017, 10:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jun 26 2017, 10:02 AM
This revision is now accepted and ready to land.Jun 26 2017, 10:02 AM
drosca requested changes to this revision.Jun 27 2017, 8:58 AM

If we want this, then only for applications tab (streams), because there is no reason not to use Plasma theme for device icons (those are standard freedesktop icon names).

This revision now requires changes to proceed.Jun 27 2017, 8:58 AM
broulik planned changes to this revision.Tue, Apr 24, 5:56 PM
broulik updated this revision to Diff 33079.Wed, Apr 25, 2:57 PM
broulik retitled this revision from Don't use plasma theme icons for stream/device icons to Don't use plasma theme icons for application icons.
  • Only disable it for applications tab
drosca accepted this revision.Wed, Apr 25, 3:05 PM
This revision is now accepted and ready to land.Wed, Apr 25, 3:05 PM
This revision was automatically updated to reflect the committed changes.