[Views] Flatten event items
AbandonedPublic

Authored by ochurlaud on Jun 24 2017, 11:29 AM.

Details

Reviewers
dvratil
mlaurent
Group Reviewers
VDG
Summary

The rounded rectangles didn't look very 2017. This patch have korganizer look more modern.

See below for the new outlook:

oldnew
Test Plan

It compiles and run. Reviewers should see if it looks good to them.

Diff Detail

Repository
R76 PIM: Event Views
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ochurlaud created this revision.Jun 24 2017, 11:29 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 24 2017, 11:29 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
mlaurent edited edge metadata.Jun 24 2017, 12:31 PM

Please add screenshot before and after.
Thanks

I applied the patch locally and tested it. I think I like the new look better but I'm not sure.
Please post screenshots so we can make it easier for other folks to compare the before and after.

... also you have some unused argument warnings in drawEventRect(). please fix those warnings.

ochurlaud edited the summary of this revision. (Show Details)Jun 25 2017, 3:16 PM

I applied the patch locally and tested it. I think I like the new look better but I'm not sure.
Please post screenshots so we can make it easier for other folks to compare the before and after.

... also you have some unused argument warnings in drawEventRect(). please fix those warnings.

Shall I fix the warning by using Q_UNUSED(..) or by changing the signature of the function? I didn't use the parameters there, but they might be useful one day...

ochurlaud edited the summary of this revision. (Show Details)Jun 25 2017, 3:28 PM
ochurlaud edited the summary of this revision. (Show Details)Jun 25 2017, 3:30 PM

Q_UNUSED() is fine

ochurlaud updated this revision to Diff 15859.Jun 25 2017, 5:38 PM
ochurlaud edited the summary of this revision. (Show Details)

Remove unused parameters from the function signature

Remove unused parameters from the function signature

I finally changed the function signature as it was adding some noise: it is simpler to add the logic back if needed...

Hi,
now it's just a rectangle ?
It's more modern ?
For me it's better with actual code because you can see when event start/end when you see round corner.
With your code we don't know it if we don't select one day before one day after.

Really I don't see the improvement here.
I am not a designer but just a rectangle I don't know if it's an improvement.

I am against this changes...

Hi,
now it's just a rectangle ?
It's more modern ?
For me it's better with actual code because you can see when event start/end when you see round corner.
With your code we don't know it if we don't select one day before one day after.

Really I don't see the improvement here.
I am not a designer but just a rectangle I don't know if it's an improvement.

I am against this changes...

So do we drop the patch or do we get the vdg in the loop?

I asked around and people found it better this way. And we didn't notice the issue you highlighted...

dvratil edited edge metadata.Jun 26 2017, 9:53 AM

I agree that the main KOrganizer view looks a bit outdated and I'm happy that you stepped up to bring us more into 2017, but Laurent is right that it's harder now to see where events end and begin, especially if you have a lot of events in your calendar. Making the border of the events more contrasting to the event color might be a good first step (although it gets tricky with custom calendar colors).

I think we should definitely bring in VDG into this, maybe ask them to take a look at the entire calendar view as a whole and get their input on this.

Yes, there might be a second iteration to do.

I add the vdg

We could use some sort of "glow" around a flat event? Essentially a deeper colour as border around the event (with square shape) and then the event itself in a lighter colour? That way the events would be easily seperated.

abetts added a subscriber: abetts.Aug 1 2017, 8:28 PM

I saw that on the Vdg Telegram group.

https://phabricator.kde.org/M43/109/

Any thoughts?

I'm not on board with making the roundrects into flat squares. A little bit of corner rounding is a nice touch. If we remove all visual ornamentation, we make our design look cold, barren, and amateurish IMHO.

I'm not on board with making the roundrects into flat squares. A little bit of corner rounding is a nice touch. If we remove all visual ornamentation, we make our design look cold, barren, and amateurish IMHO.

So basically Nate you find the result better as it currently is than in the direction I proposed?

To me, Korganizer looks very outdated. But it's surely opinion based (shared by a lot of peopleand not shared by an other lot of people) and therefore I'm not fighting too much on that.

... I'm specifically write about the month view, but it holds also for the other views

ochurlaud abandoned this revision.Oct 21 2018, 12:44 PM

D16013 implemented the same idea in a better way