The rounded rectangles didn't look very 2017. This patch have korganizer look more modern.
See below for the new outlook:
I applied the patch locally and tested it. I think I like the new look better but I'm not sure.
Please post screenshots so we can make it easier for other folks to compare the before and after.
... also you have some unused argument warnings in drawEventRect(). please fix those warnings.
now it's just a rectangle ?
It's more modern ?
For me it's better with actual code because you can see when event start/end when you see round corner.
With your code we don't know it if we don't select one day before one day after.
Really I don't see the improvement here.
I am not a designer but just a rectangle I don't know if it's an improvement.
I am against this changes...
I agree that the main KOrganizer view looks a bit outdated and I'm happy that you stepped up to bring us more into 2017, but Laurent is right that it's harder now to see where events end and begin, especially if you have a lot of events in your calendar. Making the border of the events more contrasting to the event color might be a good first step (although it gets tricky with custom calendar colors).
I think we should definitely bring in VDG into this, maybe ask them to take a look at the entire calendar view as a whole and get their input on this.
We could use some sort of "glow" around a flat event? Essentially a deeper colour as border around the event (with square shape) and then the event itself in a lighter colour? That way the events would be easily seperated.
I'm not on board with making the roundrects into flat squares. A little bit of corner rounding is a nice touch. If we remove all visual ornamentation, we make our design look cold, barren, and amateurish IMHO.
So basically Nate you find the result better as it currently is than in the direction I proposed?
To me, Korganizer looks very outdated. But it's surely opinion based (shared by a lot of peopleand not shared by an other lot of people) and therefore I'm not fighting too much on that.