Use imported targets instead of qt5_use_modules
ClosedPublic

Authored by heikobecker on Jun 23 2017, 5:18 PM.

Details

Summary

From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires
cmake 3.0. One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.

Test Plan

Builds

Diff Detail

Repository
R9 Sink
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Jun 23 2017, 5:18 PM

Rebased on top of recent changes

cmollekopf accepted this revision.Jul 29 2017, 12:48 AM
This revision is now accepted and ready to land.Jul 29 2017, 12:48 AM
This revision was automatically updated to reflect the committed changes.