Differential D6359

[Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID
ClosedPublic
Actions

Authored by broulik on Jun 23 2017, 2:04 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:d094bd37ea90: [Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID
Summary

In plasma-browser-integration the browser window is a different PID from the host that owns the MPris service leading to no media controls in task manager.

Test Plan

I now get media controls in TM for Chrome windows, both in context menu and tooltip.
VLC player still has them, too.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 23 2017, 2:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2017, 2:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jun 23 2017, 2:07 PM
This revision is now accepted and ready to land.Jun 23 2017, 2:07 PM
davidedmundson added a subscriber: davidedmundson.Jun 23 2017, 2:13 PM

why did you chose this over overriding InstancePid in the dataengine?

Closed by commit R119:d094bd37ea90: [Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID (authored by broulik). · Explain WhySep 6 2017, 12:20 PM
This revision was automatically updated to reflect the committed changes.
broulik added a comment.Sep 6 2017, 12:22 PM

why did you chose this over overriding InstancePid in the dataengine?

Because it's not the actual PID of the process. The mapping is only really needed in TM (media controller applet doesn't care), so I didn't want to "lie" about that and rather have the view do it if neccessary. (I could have added a new role to the data engine, though)

Revision Contents
Changeset List

Diff 19228

View Options

applets/taskmanager/package/contents/ui/main.qml

Loading...