Use KRun::runApplication when possible; split out and share more code.
ClosedPublic

Authored by hein on Jun 23 2017, 1:17 PM.

Details

Summary

I'm not particularly happy about adding more X11 code outside of
XWindowTasksModel, but it means greater code reuse (in something that
has experienced unwelcome drift before) and there's a precedent in
LauncherTasksModel.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Jun 23 2017, 1:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2017, 1:17 PM
hein updated this revision to Diff 15788.Jun 23 2017, 1:25 PM

Collapse the requestOpenUrls implementations as well; more sanity checking for app-service-ness.

hein updated this revision to Diff 15789.Jun 23 2017, 1:27 PM

Ref-ify.

broulik accepted this revision.Jun 23 2017, 1:28 PM
This revision is now accepted and ready to land.Jun 23 2017, 1:28 PM
This revision was automatically updated to reflect the committed changes.