qtwebengine: Add upstream chromium gn patch to make it work on Windows
AbandonedPublic

Authored by dvratil on Jun 22 2017, 9:41 PM.

Details

Reviewers
vonreth
Summary

The gn generator in Chromium in QtWebEngine 5.9.1 does generate invalid ninja files on Windows (due to not escaping ":" in paths). This upstream patch adds support for MSVC to gn to properly escape the paths in ninja rules, so that ninja does not reject the build files.

The second change in the recipe is to set the Python environment properly when running the make step (i.e. craft --make qtwebengine), instead of the compile step (which does not seem to be exist?)

This does not make QtWebEngine to build with craft yet, but after applying this patch I was able to build QtWebEngine in the craft environment by running qmake and jom directly in the source directory. I suppose that with doing some magic (like copying the source files into the build dir and than running non-shadowed build) might make QtWebEngine buildable with craft

Diff Detail

Repository
R138 Craft
Lint
Lint Skipped
Unit
Unit Tests Skipped
dvratil created this revision.Jun 22 2017, 9:41 PM
vonreth requested changes to this revision.Jun 26 2017, 10:43 AM

The patch to qtwebengine does not apply and the build has been fixed on craft master

This revision now requires changes to proceed.Jun 26 2017, 10:43 AM
dvratil abandoned this revision.Jun 26 2017, 5:29 PM