Differential D6334

[kcms/touchpad] Fix crash with 'Drag me' in X11 test area
ClosedPublic
Actions

Authored by cfeck on Jun 22 2017, 12:46 AM.

Details

Reviewers
knambiar
davidedmundson
Group Reviewers
Plasma
Commits
R119:5c3b8c7afa4a: Fix crashes with 'Drag me' in touchpad test area
Summary

Something really fishy was going on when dragging the 'Drag me' folder in the X11 test area onto itself.

Instead of using a custom QStandardItemModel with a QListView, use a QListWidget, which comes with its own model that does not allow dropping items onto other items, but It is still possible to move the icon.

Fixes https://bugs.kde.org/show_bug.cgi?id=346900 and https://bugs.kde.org/show_bug.cgi?id=366113

Test Plan

Could freely drag, no crash.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Jun 22 2017, 12:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 22 2017, 12:46 AM
davidedmundson accepted this revision.Jun 22 2017, 12:55 AM
This revision is now accepted and ready to land.Jun 22 2017, 12:55 AM
Closed by commit R119:5c3b8c7afa4a: Fix crashes with 'Drag me' in touchpad test area (authored by cfeck). · Explain WhyJun 22 2017, 4:32 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a comment.Jun 22 2017, 4:33 PM

Pushed to 5.10 and merged to master. Feel free to cherry-pick to 5.8 branch.

Revision Contents
Changeset List

Diff 15751

View Options

kcms/touchpad/src/kcm/xlib/testarea.cpp

Loading...
View Options

kcms/touchpad/src/kcm/xlib/ui/testarea.ui

Loading...