Differential D6332

[kcms/touchpad] Fix warning 'returning reference to temporary'
ClosedPublic
Actions

Authored by cfeck on Jun 22 2017, 12:24 AM.

Details

Reviewers
romangg
knambiar
davidedmundson
Group Reviewers
Plasma
Commits
R119:838777eaa6f0: Fix warning 'returning reference to temporary'
Summary

Our APIs still should not declare reference results for implicitly shared objects.

This is not a problem with the current backends, because they just return a reference to their member data. It is a problem in the virtual base, though.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Jun 22 2017, 12:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 22 2017, 12:24 AM
davidedmundson accepted this revision.Jun 22 2017, 12:56 AM
This revision is now accepted and ready to land.Jun 22 2017, 12:56 AM
Closed by commit R119:838777eaa6f0: Fix warning 'returning reference to temporary' (authored by cfeck). · Explain WhyJun 22 2017, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 15752

View Options

kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h

Loading...
View Options

kcms/touchpad/src/backends/x11/xlibbackend.h

Loading...
View Options

kcms/touchpad/src/touchpadbackend.h

Loading...