Differential D6329

[KSystemLog] Parse Apache 2.4 log file format
Changes PlannedPublic
Actions

Authored by cfeck on Jun 21 2017, 11:07 PM.

Details

Reviewers
None
Group Reviewers
KDE Applications
Summary

New parser that handles both the old as well as the new format.

Old line format:
[Fri Sep 09 10:42:29 2011] [error] [client 72.15.99.187] File does not exist: /usr/local/apache2/htdocs/favicon.ico

New line format:
[Fri Sep 09 10:42:29.902022 2011] [core:error] [pid 35708:tid 4328636416] [client 72.15.99.187] File does not exist: /usr/local/apache2/htdocs/favicon.ico

See https://httpd.apache.org/docs/2.4/logs.html

Fixes https://bugs.kde.org/show_bug.cgi?id=379933

Diff Detail

Repository
R351 KSystemLog
Lint
Lint Skipped
Unit
Unit Tests Skipped
cfeck created this revision.Jun 21 2017, 11:07 PM
cfeck updated this revision to Diff 15754.Jun 22 2017, 4:53 PM

Avoid hang when no matching ']' was found for '['.

cfeck updated this revision to Diff 15863.Jun 26 2017, 9:07 AM

Use QString::remove() to remove parsed field from line, saving temporary allocations.

aacid added a subscriber: aacid.Jun 26 2017, 9:44 PM

Something we can add to tests/ folder?

cfeck planned changes to this revision.Jun 29 2017, 10:58 AM

I will check if I can add some tests for the Apache analyzer.

Revision Contents
Changeset List

PathPackages
Msrc/modes/apache/apacheAnalyzer.h (99 lines)

Diff 15863

View Options

src/modes/apache/apacheAnalyzer.h

Loading...