Differential D6327

[ksshaskpass] Support mercurial (hg) ssh prompts
ClosedPublic
Actions

Authored by cfeck on Jun 21 2017, 9:21 PM.

Details

Reviewers
whiting
mpyne
Commits
R105:4a6d3f932c36: Support mercurial (hg) ssh prompts
Summary

The stricter parsing of ssh password prompts causes another regression for mercurial users, see https://bugs.kde.org/show_bug.cgi?id=380085

This is similar to https://phabricator.kde.org/D4540 for bug 376228, which fixed the issue for git users.

I also removed the "Case" numbering from the fallback warning, because it causes confusing diffs, as seen here.

Test Plan

I could not test.

Diff Detail

Repository
R105 KDE SSH Password Dialog
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Jun 21 2017, 9:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 21 2017, 9:21 PM
mpyne accepted this revision.Jun 24 2017, 12:52 AM

Looks good to me, and compiles/tests fine here. Though I'm not using it on any hg repos so I can't actually test the new feature, but as long as it works for you I'd say go ahead and commit.

This revision is now accepted and ready to land.Jun 24 2017, 12:52 AM
Closed by commit R105:4a6d3f932c36: Support mercurial (hg) ssh prompts (authored by cfeck). · Explain WhyJun 24 2017, 11:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (11 lines)

Diff 15816

View Options

src/main.cpp

Loading...