Properly block the edge also for touch screen edges
ClosedPublic
Actions

Authored by graesslin on Jun 20 2017, 7:41 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:6267d597311c: Properly block the edge also for touch screen edges

Summary

There was a regression introduced with bug fix eec6afe6 which added
a for pointer events only check also to doUpdateBlocking. Do to that
the edge blocking mechanism didn't work for touch edges.

BUG: 380476
FIXED-IN: 5.10.3

Test Plan

verified with xwininfo that there is no longer a window when
in full screen. Activated edges through touch and pointer

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Jun 20 2017, 7:41 PM

Restricted Application added a project: KWin. · View Herald TranscriptJun 20 2017, 7:41 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

I've also tested this patch on a few full screen games. That bug is gone.

This revision is now accepted and ready to land.Jun 20 2017, 7:55 PM

Closed by commit R108:6267d597311c: Properly block the edge also for touch screen edges (authored by graesslin). · Explain WhyJun 26 2017, 8:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/x11/standalone/edge.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15663	3b9ccc6		Jun 20 2017, 7:41 PM	★	★
Diff 2	15893	97fa72e	R108:6267d597311ccea26a8e70d57bd730ad13d146c2	Jun 26 2017, 8:06 PM	★	★

Diff 15893

View Options

plugins/platforms/x11/standalone/edge.cpp