All buildings are now rendered as GeoDataBuildings
Loks good on quick sight, though I would like a unit test for the building height extraction method as discussed.
Regarding the node reduction, how did you test this? I am missing changes in the osm plugin to ensure buildings are written to osm xml and o5m files. I guess that at the moment tools like kml2kml and likewise the vector tile creation tool do not write buildings anymore. Can you look into it?
@rahn Can you review this as well? I'd like to have more eyes on it as it touches some pretty sensitive areas of the vector tiling pipeline.
Wouldn't hurt to also have
Q_ASSERT(d->m_multiGeometry.size() == 1);
I think this violates "The default unit is meters", see https://wiki.openstreetmap.org/wiki/Key:height#Height_of_buildings
Please use IN2M (from MarbleGlobal.h) instead of 0.0254
Do we need to care (e.g. Q_ASSERT on) the value of m_polygon, m_building here? Same in setPolygon.
|68 ↗||(On Diff #16029)|
Can we have a case where no unit is specified, too?
See Dennis' comment below: MarbleGlobal.h also features FT2M to convert feet to meters.
Should these really be marked explicit? Although C++11 allows for implicit conversion for more than a single parameter that case isn't practically relevant I guess.