Use Q_FALLTHROUGH (with compat code for Qt < 5.8.0)
ClosedPublic
Actions

Authored by kossebau on Jun 20 2017, 4:38 PM.

Details

Reviewers

Group Reviewers

Commits

R32:5911dad27df0: Use Q_FALLTHROUGH (with compat code for Qt < 5.8.0)
R33:5911dad27df0: Use Q_FALLTHROUGH (with compat code for Qt < 5.8.0)

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jun 20 2017, 4:38 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 20 2017, 4:38 PM

Tested as is with Qt 5.9.0, and by changing Q_FALLTHROUGH() to KDEV_FALLTHROUGH() and removing the #if QT_VERSION < QT_VERSION_CHECK(5,8,0), so I had once the Qt and once the fallback version.

kfunk accepted this revision.Jun 20 2017, 7:39 PM

This revision is now accepted and ready to land.Jun 20 2017, 7:39 PM

Closed by commit R33:5911dad27df0: Use Q_FALLTHROUGH (with compat code for Qt < 5.8.0) (authored by kossebau). · Explain WhyJun 20 2017, 9:49 PM

This revision was automatically updated to reflect the committed changes.

aaronpuchert mentioned this in D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.Sep 22 2018, 5:06 PM

Revision Contents
Changeset List

			Path	Packages
M			language/duchain/navigation/abstractnavigationcontext.cpp (4 lines)
M			language/duchain/stringhelpers.cpp (4 lines)
M			plugins/quickopen/quickopenwidget.cpp (3 lines)
M			qtcompat_p.h (23 lines)