Make center action toggle between centered and regular
AbandonedPublic

Authored by gladhorn on Jun 20 2017, 9:19 AM.

Details

Reviewers
gateau
Summary

While playing with the features I got stuck centered (setting the offset
to 0 manually works, but I expected the action to get me out of centered
mode again).

Diff Detail

Repository
R375 KRuler
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
gladhorn created this revision.Jun 20 2017, 9:19 AM
gateau edited edge metadata.Jun 21 2017, 4:57 PM

Ah, I got stuck with that too! but I solved it in a different way: I merged the direction (left-to-right, right-to-left) and center origin concepts into 3 modes, which can be switched with F2, F3 and F4. You can build the work branch of my scratch repo (git@git.kde.org:clones/kruler/gateau/kruler) to give it a try.

These changes are a bit controversial: they drop the percentage feature and turn the custom origin feature into a "symmetric" mode. From what I understand, this matches more with what users want to do with the custom origin feature (see bugzilla entry: https://bugs.kde.org/show_bug.cgi?id=76898)

gladhorn abandoned this revision.Jun 22 2017, 7:33 AM

Nice, I leave it up to you then :) Just found it curious.