Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
At least one change is required, but please let's talk first if this mass change is really needed.
| Messages.sh | ||
|---|---|---|
| 2–3 | '/tests/' should be excluded as before, and rc.cpp is already captured by the find commnand | |
Comment Actions
Could you please recheck the patch? It does not apply for me on top of the current master.
Comment Actions
In fact that's to be expected, it depends on other patches currently in review, phabricator is not great at showing those, here they are:
- https://phabricator.kde.org/D6170
- https://phabricator.kde.org/D6171
- https://phabricator.kde.org/D6172
- https://phabricator.kde.org/D6173
- https://phabricator.kde.org/D6174
Hopefully I didn't miss any, and you probably don't need to apply them all first.
Comment Actions
Oh, thanks, I will apply them as well. You can use "Edit Related Revisions..." to add dependencies between reviews.
Comment Actions
Applied the pile of dependent patches, the translation system works (the translated strings are shown correctly).