Support for variadic functions in documentation popup.
ClosedPublic

Authored by pprkut on Jun 18 2017, 10:53 AM.

Details

Summary

This shows the documentation for functions defined as

function foo(...$params) {}
function foo(A ...$params) {}

in the form of

void foo ([mixed ...params])
void foo ([A ...params])

In the first case, $params itself is shown as

array params

and in the latter as

array of (A) params

Diff Detail

Repository
R52 KDevelop: PHP Support
Branch
variadic_doc
Lint
No Linters Available
Unit
No Unit Test Coverage
pprkut created this revision.Jun 18 2017, 10:53 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 18 2017, 10:53 AM
pprkut updated this revision to Diff 15547.Jun 18 2017, 12:52 PM

Fixed showing correct structure type for variadic arguments.

pprkut retitled this revision from [WIP] Support for variadic functions in documentation popup. to Support for variadic functions in documentation popup..Jun 18 2017, 12:55 PM
pprkut edited the summary of this revision. (Show Details)
zhigalin accepted this revision.Jun 18 2017, 1:13 PM
zhigalin added a subscriber: zhigalin.

Looks good

This revision is now accepted and ready to land.Jun 18 2017, 1:13 PM
aacid added a subscriber: aacid.Jun 18 2017, 5:01 PM

Any reason this hasn't been pushed?

This revision was automatically updated to reflect the committed changes.