Differential D624

OSX: Kdelibs4ConfigMigrator needs to happen after App object is created.
ClosedPublic
Actions

Authored by amccann on Dec 4 2015, 4:50 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:41ae241cc52b: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created.
Summary

Calling migrator before the application object was created caused qt platform not to load on OSX, resulting in segfault/abort.

Test Plan

Verify no longer segfaults on OSX.

@kfunk, I presume that the ConfigMigrator can run after the Application object is created?

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amccann updated this revision to Diff 1442.Dec 4 2015, 4:50 AM
amccann retitled this revision from to OSX: Kdelibs4ConfigMigrator needs to happen after App object is created..
amccann updated this object.
amccann edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 4 2015, 4:50 AM
amccann edited the test plan for this revision. (Show Details)Dec 4 2015, 4:54 AM
amccann added reviewers: KDevelop, kfunk.
amccann added a project: KDevelop.
amccann added a subscriber: kfunk.
kfunk accepted this revision.Dec 4 2015, 7:30 AM
kfunk edited edge metadata.

Thanks!

I've seen warnings coming up on Linux and was wondering if it's been related to my patch...

This revision is now accepted and ready to land.Dec 4 2015, 7:30 AM
Closed by commit R32:41ae241cc52b: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created. (authored by amccann). · Explain WhyDec 4 2015, 5:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/main.cpp (10 lines)

Diff 1448

View Options

app/main.cpp

Loading...