it's possible that a window gets an expose event even if the qwindow
is not visible, this can cause problems like the window decoration
created too soon, before kwin's ShellClient is created, so
setting the decoration mode has no effect, it can give
windows that have for an instant the wrong geometry as it
includes a non existing decoration
Details
Details
- Reviewers
graesslin davidedmundson - Group Reviewers
Plasma - Commits
- R135:7ace568d2374: check window visibility at expose event
i now get the decoration client always being created after
the decoratininterface in kwin, so setting borders to none
actually works
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
it's possible that a window gets an expose event even if the qwindow
is not visible
How?
QWaylandXdgSurfaceV6::handleExpose returns false if it's not configured yet, and we can't receive a configure before we've created the shell, and we don't create the shell till we're visible.
Comment Actions
Edit.
qwaylandwindow code is:
if (! (mShellSurface && mShellSurface->handleExpose(rect)))
QWindowSystemInterface::handleExposeEvent(window(), rect);so if there's no shell, we always send the expose event. Sounds mad to me, but does mean this patch makes sense.
Comment Actions
tough i clearly receive an expose event right after windows are created, before they are set to visible (perhaps when qtwayland is creating the surface the first time before is shown?)
Comment Actions
Ha! indeed it is, and we'll probably need to do similar things in the other places we do the expose event workaround