Implement the new libksieve password provider class
ClosedPublic
Actions

Authored by aacid on Jun 12 2017, 11:26 PM.

Details

Reviewers

dvratil
mlaurent

Commits

Repository

R206 KMail

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

src/sieveimapinterface/kmsieveimappasswordprovider.cpp
28	indent here

mlaurent requested changes to this revision.Jun 13 2017, 4:39 AM

This revision now requires changes to proceed.Jun 13 2017, 4:39 AM

Missing to increase libksieve version, after that you need to increase dependency

Fix Laurent comments

Please recreate a diff between master and not 17.04 thanks

This revision now requires changes to proceed.Jun 14 2017, 4:55 AM

I am confused by your comments, the diff is against master and you're commenting in places i have no changes?

src/CMakeLists.txt
44–45	I haven't removed anything from here
389	There's no diff here
394	There's no diff here

Indeed now the diff is ok.
But indeed now it's against master
I don't understand why yesterday it was against 17.04... But in phabricator ?

it's ok for me :)
Thansk

This revision is now accepted and ready to land.Jun 15 2017, 4:39 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (2 lines)
M		src/CMakeLists.txt (1 line)
M		src/kmmainwidget.h (2 lines)
M		src/kmmainwidget.cpp (9 lines)
P		src/sieveimapinterface/kmsieveimappasswordprovider.h (36 lines) Copied from src/sieveimapinterface/tests/sievemanagerdialog/sievemanagerdialog.cpp
A	M	src/sieveimapinterface/kmsieveimappasswordprovider.cpp (55 lines)
M		src/sieveimapinterface/tests/sievedebugdialog/CMakeLists.txt (3 lines)
M		src/sieveimapinterface/tests/sievedebugdialog/sievedebugdialog.cpp (4 lines)
M		src/sieveimapinterface/tests/sievemanagerdialog/CMakeLists.txt (3 lines)
P		src/sieveimapinterface/tests/sievemanagerdialog/sievemanagerdialog.cpp (4 lines) Copied to src/sieveimapinterface/kmsieveimappasswordprovider.h
M		src/sieveimapinterface/tests/vacation/CMakeLists.txt (3 lines)
M		src/sieveimapinterface/tests/vacation/main.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15410	f10d79c		Jun 12 2017, 11:26 PM	★	★
Diff 2	15441	9b47218	Fix Laurent comments	Jun 13 2017, 11:23 PM	★	★
Diff 3	15477	cd95403	R206:ab3c0c588029c0e0dd293ab15f23dc6c719be191	Jun 15 2017, 8:18 PM	★	★