Differential D6179

Reenable icon border menu
ClosedPublic
Actions

Authored by croick on Jun 10 2017, 8:14 PM.

Details

Reviewers
kwrite-devel
kfunk
Group Reviewers
KDevelop
Commits
R33:f27e8c140a51: Reenable icon border menu
R32:f27e8c140a51: Reenable icon border menu
Summary
  • current functionality preserved
  • allow enabling/disabling bookmarks
  • set bookmark or breakpoint as standard left-click action

BUG: 267806

Test Plan

Activate icon border and right-click to open menu.
Left-click into icon border to add/remove default mark.

Diff Detail

Repository
R33 KDevPlatform
Branch
iconborder
Lint
No Linters Available
Unit
No Unit Test Coverage
croick created this revision.Jun 10 2017, 8:14 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 10 2017, 8:14 PM
croick added a comment.Jun 10 2017, 8:17 PM

I'm not sure if that feature is really wanted, as it was removed intentionally.
I also tried to create a custom "right-click onto no mark" context menu, but this would require changes to KTextEditor which does not emit signals when there is no mark in the current line.

kfunk added a subscriber: kfunk.Jul 6 2017, 5:42 PM

Just tested this, I like it. Just a couple of minor issues then this is good to go.

debugger/breakpoint/breakpointmodel.cpp
148

Please rename breakpointA -> breakpointAction

162

a -> triggeredAction

kfunk added a reviewer: kwrite-devel.Jul 6 2017, 5:44 PM

Also, that "Set Default Mark Type" menu from ktexteditor should be improved.

It currently shows the actions not as an mutually exclusive group. Fix is here: https://stackoverflow.com/questions/23429663/qt-mutually-exclusive-checkable-menu-items -- You'd need to fix ktexteditor.git:src/view/kateviewhelpers.cpp

kfunk requested changes to this revision.Jul 6 2017, 5:47 PM
This revision now requires changes to proceed.Jul 6 2017, 5:47 PM
Closed by commit R33:f27e8c140a51: Reenable icon border menu (authored by croick, committed by kfunk). · Explain WhyJul 6 2017, 5:57 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.EditedJul 6 2017, 6:09 PM
In D6179#122352, @kfunk wrote:

Also, that "Set Default Mark Type" menu from ktexteditor should be improved.

It currently shows the actions not as an mutually exclusive group. Fix is here: https://stackoverflow.com/questions/23429663/qt-mutually-exclusive-checkable-menu-items -- You'd need to fix ktexteditor.git:src/view/kateviewhelpers.cpp

Handled in: https://phabricator.kde.org/D6535

Edit: Fixed the link above.

croick added a comment.Jul 7 2017, 6:58 AM

Ah, I did the same, but now understood, that you actually meant this revision: D6535

Revision Contents
Changeset List

Diff 15340

View Options

debugger/breakpoint/breakpointmodel.cpp

Loading...
View Options

shell/textdocument.cpp

Loading...