Fix build with future glibc (major/minor macros), BSD compatible
ClosedPublic
Actions

Authored by asturmlechner on Jun 10 2017, 3:49 PM.

Details

Reviewers

graesslin

Group Reviewers

Plasma

Commits

Summary

Also adding sys/types.h which is not implicitly included from all over.

Thanks-to: [ade] in #kde-devel

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJun 10 2017, 3:49 PM

Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript

If I understand correctly this is no longer a change suited for the 5.8 branch.

In D6175#115496, @graesslin wrote:

If I understand correctly this is no longer a change suited for the 5.8 branch.

Okay, then I guess 5.10 would be it?

Personally I would say master only as it is for future glibc.

Switch to master

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJul 25 2017, 4:49 PM

Please reference bug 376505

This revision is now accepted and ready to land.Jul 25 2017, 5:31 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			logind.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15332	c6dc3ed		Jun 10 2017, 3:49 PM	★	★
Diff 2	17180	c29d609	Switch to master	Jul 25 2017, 4:49 PM	★	★
Diff 3	17186	f5f1447	R108:35c278e525377723028a1417a705d28517fa183f	Jul 25 2017, 8:16 PM	★	★