Differential D6165

Add suggestions from the kde-core team
ClosedPublic
Actions

Authored by rizzitello on Jun 9 2017, 7:46 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava

Diff Detail

Repository
R232 AtCore
Branch
consts
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello created this revision.Jun 9 2017, 7:46 PM
patrickelectric requested changes to this revision.Jun 10 2017, 6:11 PM
patrickelectric added inline comments.
src/atcore.cpp
237

':', ''

This revision now requires changes to proceed.Jun 10 2017, 6:11 PM
rizzitello updated this revision to Diff 15338.Jun 10 2017, 6:29 PM
rizzitello edited edge metadata.
rizzitello marked an inline comment as done.
  • Remove the PrinterStatus struct and place its items into the d ptr
src/atcore.cpp
237

Unfortunately that doesn't build so i will use QChar::Null instead

patrickelectric added inline comments.Jun 10 2017, 6:47 PM
src/atcore.cpp
237

can you use remove ?

patrickelectric accepted this revision.Jun 10 2017, 7:25 PM
This revision is now accepted and ready to land.Jun 10 2017, 7:25 PM
patrickelectric added inline comments.Jun 10 2017, 7:25 PM
src/atcore.cpp
237

After some research, "" is the best solution

rizzitello updated this revision to Diff 15339.Jun 10 2017, 7:27 PM
  • Remove the PrinterStatus struct and place its items into the d ptr
aacid added a subscriber: aacid.Jun 12 2017, 10:40 PM
aacid added inline comments.
src/atcore.h
132

In my mind this is actually not const, since pop implies modyfing the state?

src/seriallayer.h
120

Same as above.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.h (20 lines)
Msrc/atcore.cpp (37 lines)
Msrc/seriallayer.h (6 lines)
Msrc/seriallayer.cpp (6 lines)

Diff 15339

View Options

src/atcore.h

Loading...
View Options

src/atcore.cpp

Loading...
View Options

src/seriallayer.h

Loading...
View Options

src/seriallayer.cpp

Loading...