Add a integration test suite and fix a signal connect bug when attaching reports
ClosedPublic

Authored by sitter on Jun 9 2017, 11:17 AM.

Details

Summary
  • Fix radios' updating UI as they are toggling not buttonclicking :(
  • add a cmdline option to enable bringing up the dialog directly. in a testing scenario it makes sense to skip the notification popup thing and go directly to the dialog
  • new env var DRKONQI_KDE_BUGZILLA_URL to override the bugzilla url. for testing purposes we'll want to change the bugzilla url to point to a double instance but otherwise not impact functionality of drkonqi
  • new env var DRKONQI_IGNORE_QUALITY to bypass trace quality checks. during testing a proper trace may not be creatable, setting the env var allows bypassing the quality constraints
  • set a11y names on text inputs to facilitate a11y enablement (also allows finding them through at-spi for testing purposes ;))

add an integration test based on xvfb+dbus+at-spi

  • suite wrapper program isolates the environment a bit, starts a xvfb instance and runs a session bus inside, then starts the actual tests from inside the isolated environment
  • duplicate_attach_test.rb starts an xmlrpc server, a defunct ruby, and a drkonqi to trace the defunct ruby. it then uses at-spi to massage the drkoknqi GUI into attaching a new trace to a bug via xmlrpc server.
  • the xmlrpc server partially falls through to bugstest.kde.org but mostly doubles for bugzilla

fix a connect bug when attaching a new trace to an existing report

Test Plan

make test should™ run the integration test assuming requirements are met (ruby+atspi+xmlrpc+xvfb-run).

XEPHYR=1 make test will run the test through xephyr rather than xvfb, which is somewhat more useful for test writing and debugging.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
sitter created this revision.Jun 9 2017, 11:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 9 2017, 11:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter retitled this revision from listen to toggle signals to properly track radiobuttons to Add a integration test suite and fix a signal connect bug when attaching reports.Jun 9 2017, 11:18 AM
sitter edited the summary of this revision. (Show Details)
sitter edited the test plan for this revision. (Show Details)Jun 9 2017, 11:21 AM
sitter edited the summary of this revision. (Show Details)
sitter updated this revision to Diff 15303.Jun 9 2017, 11:32 AM

fix a11y names of input fields

sitter updated this revision to Diff 15415.Jun 13 2017, 7:27 AM

do not hardcode drkonqi but use the target_file of the actual exec target

sitter updated this revision to Diff 15417.Jun 13 2017, 7:49 AM

do not hardcode at-spi-bus-launcher either

mart accepted this revision.Jun 20 2017, 8:16 AM
This revision is now accepted and ready to land.Jun 20 2017, 8:16 AM
This revision was automatically updated to reflect the committed changes.