Compiles fine under Linux
Compiles fine under Windows
Details
- Reviewers
bcooksley dfaure marten - Commits
- R320:ce7124beac8a: Make compile under Windows/MSVC
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
The utime issue in kio_sftp is not trivial to fix, let's just make it compile for now for KDE CI.
+1 from me
CMakeLists.txt | ||
---|---|---|
157 | Used for getting the resource limit for closing all child process FDs. Could be completely replaced by fcloseall() if available for Unix or _fcloseall() for Windows, either conditionally on Q_OS_type or using a configure test. |
CMakeLists.txt | ||
---|---|---|
157 | It would be useful to get the information from marten's comment into the CMakeLists.txt, for the next reader. | |
164 | Everywhere else we just skip calling utime() on non-unix. Long term, QFileDevice::setFileTime is coming, slowly. | |
archive/kio_archivebase.cpp | ||
41 | I'm surprised that this is needed, we use S_ISDIR in KIO without such #define. |
archive/kio_archivebase.cpp | ||
---|---|---|
41 | None of the files using S_ISDIR are actually compiled on Windows. src/ioslaves/ftp/ftp.cpp 1558: //if ( S_ISDIR( (mode_t)ftpEnt.type ) ) src/ioslaves/trash/trashimpl.cpp 1164: if ((S_ISDIR(buff.st_mode)) // must be a dir 1177: && (S_ISDIR(buff.st_mode)) // must be a dir 1200: && (S_ISDIR(buff.st_mode)) // must be a dir ftp.cpp: Commented line [1] if(WIN32) set(kio_trash_PART_SRCS kio_trash_win.cpp kiotrashdebug.cpp) else() # Files that are shared with the KCM. Unix specific. set (trashcommon_unix_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/trashimpl.cpp ... |
LGoF (Looks Good on FreeBSD)
CMakeLists.txt | ||
---|---|---|
157 | While fcloseall() is listed as a GNU extension in the Linux man pages, it is also available on FreeBSD -- but not OpenBSD or NetBSD. A configure test seems appropriate. |