[Notes Applet] Show formatting options when it has focus
ClosedPublic

Authored by broulik on Jun 8 2017, 10:09 AM.

Details

Summary

This is a lot less cumbersome than manually toggling the formatting button.
It ensures clean looks when the applet is not being edited while making it more prominent to the user that there is actually formatting available.

Test Plan

Placed a sticky note, clicked the text field, formatting options appeared. Resized the applet, they went away when the applet became too small. Also tabbing between textfield and buttons worked fine.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jun 8 2017, 10:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 8 2017, 10:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jun 8 2017, 10:09 AM

Seems sensible it doesn't save any space as we anchor the text above the button anyway.

applets/notes/package/contents/ui/main.qml
238

probably don't need this Row then, it's just there to make toggling easier?

242

just

root.Plasmoid.activeFoocus

after D6512

broulik updated this revision to Diff 15281.Jun 8 2017, 11:59 AM
  • Use root.Plasmoid.activeFocus
broulik edited the test plan for this revision. (Show Details)Jun 8 2017, 11:59 AM
mart accepted this revision.Jun 8 2017, 12:32 PM
This revision is now accepted and ready to land.Jun 8 2017, 12:32 PM
This revision was automatically updated to reflect the committed changes.