Differential D6148

[Icon Applet] Repopulate if URL didn't change
ClosedPublic
Actions

Authored by broulik on Jun 8 2017, 8:04 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:45e4f998e9e8: [Icon Applet] Repopulate if URL didn't change
Summary

We used to always delete the backing .desktop file if we changed a property in a Link (to a document) hoping that setUrl would call populate. However, it won't do that if the URL didn't change, so if you only changed the icon, the .desktop file was removed and never re-created, breaking the applet.

BUG: 380922
FIXED-IN: 5.10.2

Test Plan

(Possibly for 5.8 branch also) The icon stuff is only 5.9 and upward

  • Dropped app on desktop, clicked it, worked
  • Changed icon for app, worked
  • Changed name for app, worked
  • Dropped file on desktop, clicked it, worked
  • Changed icon for file link, now works, didn't before
  • Changed URL for file link, still works

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 8 2017, 8:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 8 2017, 8:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jun 8 2017, 8:17 AM
mart accepted this revision.Jun 8 2017, 12:34 PM
This revision is now accepted and ready to land.Jun 8 2017, 12:34 PM
Closed by commit R120:45e4f998e9e8: [Icon Applet] Repopulate if URL didn't change (authored by broulik). · Explain WhyJun 9 2017, 1:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/icon/iconapplet.cpp (16 lines)

Diff 15306

View Options

applets/icon/iconapplet.cpp

Loading...