Differential D6132

katemdi: Fix deprecation warnings
ClosedPublic
Actions

Authored by kfunk on Jun 7 2017, 7:09 AM.

Details

Reviewers
cullmann
Commits
R40:d6f63e023788: katemdi: Fix deprecation warnings
Summary
/home/kfunk/devel/src/kf5/kate/kate/katemdi.cpp:322:5: warning: 'appendTab' is deprecated [-Wdeprecated-declarations]
    appendTab(icon, newId, text);
    ^
/home/kfunk/devel/install/kf5/include/KF5/KWidgetsAddons/kmultitabbar.h:138:35: note: 'appendTab' has been explicitly marked deprecated here
    KWIDGETSADDONS_DEPRECATED int appendTab(const QPixmap &pic, int id = -1, const QString &text = QString());
```                                  ^

The alternative appendTab function is part of KF5 5.13, thus we need a
version bump.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Jun 7 2017, 7:09 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptJun 7 2017, 7:09 AM
cullmann accepted this revision.Jun 8 2017, 11:41 AM
cullmann added a subscriber: cullmann.

Looks ok, version bump should be no issue, too.
Thanks for comment in cmake file

This revision is now accepted and ready to land.Jun 8 2017, 11:41 AM
Closed by commit R40:d6f63e023788: katemdi: Fix deprecation warnings (authored by kfunk). · Explain WhyJun 8 2017, 12:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mkate/katemdi.h (8 lines)
Mkate/katemdi.cpp (4 lines)

Diff 15282

View Options

CMakeLists.txt

Loading...
View Options

kate/katemdi.h

Loading...
View Options

kate/katemdi.cpp

Loading...