By the time we leave the method, the QMimeData is deleted by the DragArea's drop event being destroyed leading to a crash.
CHANGELOG: Fixed crash when dropping files on desktop with KDeclarative from KDE Frameworks 5.35
BUG: 380806
FIXED-IN: 5.10.1
Details
Details
- Reviewers
hein fvogt - Group Reviewers
Plasma - Commits
- R119:77f1e675178a: [Folder View] Use a copy of QMimeData in signal handler
There's no copy operator. Stackoverflow mentions some weirdness on Windows [1] but that shouldn't affect us.
- Can still re-arrange files
- Dropping an external file prompts to copy/link/move/create matching applet and all of those options work now without a crash
DropJob doesn't always emit popupAboutToShow (when there's only one possible action (e.g. only "move" to trash) where we could leak the QMimeData but this is an issue also for the containment as then we don't get a chance to add possible applet to be added. This needs to be addressed separately in one form or the other.
[1] https://stackoverflow.com/questions/13762140/proper-way-to-copy-a-qmimedata-object
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.