The krazy2 analysis reports crashy code in 10 cases, the patch changes the code according to http://blogs.kde.org/node/3919.
Details
Details
- Reviewers
brauch - Group Reviewers
KDevelop - Commits
- R32:6ccc2a327841: Replace crashy dialogs by QPointer version (krazy2 analysis)
no tests performed
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
LGTM, I have actually seen crashes a few times which I would account to something related.
| languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp | ||
|---|---|---|
| 182 ↗ | (On Diff #15123) | Not checked. |
Comment Actions
@anthonyfieroni does this look good to you?
@brauch Should i commit? (Since @croick doesn't have commit access)
Comment Actions
Now looks good to me. Sven knows better, but sometimes exec() is checked against QDialog::Rejected other time against *not*.
Comment Actions
I was asking this myself, so I checked the Qt documentation and in one of the examples of QFileDialog they do it like I proposed.