implement basic rectangle plugins
AbandonedPublic

Authored by stefant on Jun 2 2017, 5:55 PM.

Details

Reviewers
sandroandrade
Summary

i added a plugin folder with 3 qml rectangles which are loaded dynamically into minuet's loadscreen.
When pressing on a button, the specific rectangle qml file will be loaded

Diff Detail

Repository
R163 Minuet
Branch
GSOC2017-Stefan
Lint
No Linters Available
Unit
No Unit Test Coverage
stefant created this revision.Jun 2 2017, 5:55 PM
sandroandrade requested changes to this revision.Jun 7 2017, 2:19 AM

Please don't push binary (compiler generated) assets into the repository (ex: src/app/plugins/rect2/students.qmlc).

This is fine, but it doesn't load the plugin's qml file and create the item dinamycally as a child of all plugin's parent.

What do we need:

  1. Remove temporarily the PianoView e create a MultipleInstrumentView, containing an empty TabBar (from QtQuickControls 2).
  2. For each found plugin, you should create a new Tab in the TabBar, whose title is the plugin's title.
  3. Inside the TabBar's contents, you should place the top QML element defined in plugin's qml file.

At the end, you should have a TabBar with tree tabs, each one containing the rectangles you defined for each plugin.

CMakeLists.txt.user
1

Byproducts of compilation process shouldn't be pushed into the repository ...

src/app/main.cpp
73

Why have you added those two blank lines?

src/app/plugincontroller.cpp
88

What's the reason for that? Minuet is expected to find a suitable soundController. If it didn't please check your installation and/or dev environment.

src/app/plugins/rect1/rect1.qml
7

I'd use "anchors.fill: parent" to make the plugin fill the entire parent's area

src/app/plugins/rect2/rect2.qml
7

The same here

src/app/plugins/rect3/rect3.qml
7

The same here

src/app/qml/Main.qml
190

This is fine but, so far, it only shows the plugin names in a ListView. See comments below ...

src/app/uicontroller.h
27

No need for include, use a forward declaration:

class QQmlApplicationEngine;

65

Please make the engine a member-data and define initialize2 with no parameters.

Rename initialize2 to initializePlugins.

This revision now requires changes to proceed.Jun 7 2017, 2:19 AM
stefant abandoned this revision.Jun 29 2017, 5:37 PM