Add a test that adds a notification and closes it
ClosedPublic

Authored by apol on Jun 1 2017, 2:25 PM.

Details

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D6059_1
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jun 1 2017, 2:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 1 2017, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a reviewer: VDG.Jun 1 2017, 2:26 PM
mck182 added a subscriber: mck182.Jun 1 2017, 3:21 PM

This was discussed at length in https://phabricator.kde.org/D4215

What's the reasoning behind this change?

mart added a subscriber: mart.Jun 1 2017, 9:08 PM

triggering the action would close the notification anyways, so it may be seen as a consistency between notifications with action and not

apol added a comment.Jun 1 2017, 11:04 PM

This was discussed at length in https://phabricator.kde.org/D4215

What's the reasoning behind this change?

The reasoning is Kai complained about it in IRC. If it was decided against I'll redo the patch keeping the test and closing the notification differently.

apol updated this revision to Diff 15069.Jun 1 2017, 11:11 PM

Just add a test

apol retitled this revision from Close notifications that don't have a default action by clicking to Add a test that adds a notification and closes it.Jun 1 2017, 11:11 PM
apol removed a reviewer: VDG.

That's up to Kai/VDG, I guess. I was just wondering what changed
from the previous patch where everyone agreed to not do it because
it would be confusing.

apol added a comment.Jun 5 2017, 11:09 AM

Now it's just adding a test, it should be a straightforward review...

apol updated this revision to Diff 15186.Jun 5 2017, 9:27 PM

Fix logic

apol updated this revision to Diff 15187.Jun 5 2017, 9:29 PM

Rebase to Plasma/5.10

davidedmundson accepted this revision.Jun 5 2017, 9:43 PM
This revision is now accepted and ready to land.Jun 5 2017, 9:43 PM
This revision was automatically updated to reflect the committed changes.