Add separate category for "Runtimes" in settings and module listing
ClosedPublic
Actions

Authored by kossebau on May 30 2017, 11:31 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

Grouoing the runtimes together adds some more structure back and
helps looking up the entries.

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol added a subscriber: apol.

apol added inline comments.

shell/uicontroller.cpp
537	These two look swapped. Can you check?

This revision is now accepted and ready to land.May 30 2017, 1:25 PM

shell/uicontroller.cpp
537	What do you mean by swapped? Actually the whole old code here is screwed, as the API dox of `ConfigDialog::addConfigPage(ConfigPage* page, ConfigPage* next = nullptr)` claims something else than what the implementation does (signature also changes from `next` to `previous`. But the added code follows the pattern, and the runtime result seems okay. I stayed away from changing this for this patch, only planned to handle that as future patch.

This revision was automatically updated to reflect the committed changes.

		Path
M		interfaces/configpage.h (3 lines)
M		plugins/docker/dockerpreferences.h (1 line)
M		plugins/docker/dockerpreferences.cpp (5 lines)
M		plugins/docker/kdevdocker.json (2 lines)
M		plugins/flatpak/kdevflatpak.json (2 lines)
M		shell/CMakeLists.txt (1 line)
M		shell/settings/pluginpreferences.cpp (1 line)
A	M	shell/settings/runtimespreferences.h (48 lines)
A	M	shell/settings/runtimespreferences.cpp (62 lines)
M		shell/uicontroller.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14972	3c33ae9		May 30 2017, 11:31 AM	★	★
Diff 2	14980	3c33ae9	R33:c91997c32d4e2cac23064f20f17058a7d4242a0a	May 30 2017, 1:45 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
dfc80f1e5eb6	6e1abe1efbaf	3c33ae91cfc2	Friedrich W. H. Kossebau	Add separate category for "Runtimes" in settings and module listing (Show More…)	May 30 2017, 11:27 AM