Differential D6008

Give a parent to KMoreToolsMenuFactory menus
ClosedPublic
Actions

Authored by elvisangelaccio on May 29 2017, 11:00 AM.

Details

Reviewers
mart
dfaure
Group Reviewers
Frameworks
Commits
R304:0b44a25b5df4: Give a parent to KMoreToolsMenuFactory menus
Summary

A QMenu without a parent will be wrongly positioned on Wayland.

Test Plan

KMoreToolsMenuFactory menu in Dolphin status bar now works on wayland

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 29 2017, 11:00 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
elvisangelaccio added a comment.May 29 2017, 11:01 AM

Note: we could also deprecate the current createMenuFromGroupingNames() in favor of a new createMenuFromGroupingNames() that takes an addition QWidget* argument. Not sure which way is the best.

elvisangelaccio updated this revision to Diff 15197.Jun 6 2017, 9:18 AM
  • Bumped @since
dfaure accepted this revision.Jul 1 2017, 6:38 PM
This revision is now accepted and ready to land.Jul 1 2017, 6:38 PM
Closed by commit R304:0b44a25b5df4: Give a parent to KMoreToolsMenuFactory menus (authored by elvisangelaccio). · Explain WhyJul 10 2017, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16464

View Options

src/kmoretools/kmoretoolsmenufactory.h

Loading...
View Options

src/kmoretools/kmoretoolsmenufactory.cpp

Loading...