Fix build with gcc7
AbandonedPublic

Authored by wbauer on May 29 2017, 8:52 AM.

Details

Reviewers
None
Group Reviewers
Kdenlive
Summary

This fixes the following errors when building with gcc7:

  • /home/abuild/rpmbuild/BUILD/kdenlive-17.04.1/src/scopes/audioscopes/spectrogram.cpp:244:113: error: call of overloaded 'abs(unsigned int)' is ambiguous

fixed by casting leftDist to int

  • /home/abuild/rpmbuild/BUILD/kdenlive-17.04.1/src/profiles/tree/profiletreemodel.cpp: In constructor 'ProfileTreeModel::ProfileTreeModel(QObject*)': /home/abuild/rpmbuild/BUILD/kdenlive-17.04.1/src/profiles/tree/profiletreemodel.cpp:146:21: error: 'function' is not a member of 'std'

fixed by adding a missing "#include <functional>"

BUG: 375647
BUG: 379688

Test Plan

Builds fine on openSUSE Tumbleweed after the recent switch to gcc7 as default compiler.
Also still builds fine on older versions.

Diff Detail

Repository
R158 Kdenlive
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer created this revision.May 29 2017, 8:52 AM
wbauer edited the summary of this revision. (Show Details)May 29 2017, 9:01 AM
vpinon added a subscriber: vpinon.Jun 27 2017, 7:11 PM

Hello,
Many thanks for trying to contribute and sorry for handling poorly communication around that patch.
Cheers,
Vincent

No problem.
The only important thing is that the build problems were fixed. ;-)