Properly support clang/gcc as KDECOMPILER
ClosedPublic

Authored by kfunk on May 29 2017, 7:58 AM.

Details

Summary

This patch allows me to build KDevelop under macOS again

TODO: Get rid off uses of "Compile"/"UseClang" setting.

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.May 29 2017, 7:58 AM
kfunk added a comment.May 29 2017, 8:01 AM

There are a couple of uses of supportsClang in craft.git, wondering if we should just try to get rid off them. Opinions?

portage/win32libs/llvm-meta/llvm/llvm.py
26:        self.supportsClang = utils.utilsCache.findApplication("clang") is not None

portage/dev-util/clazy/clazy.py
20:        self.supportsClang = False

bin/BuildSystem/BuildSystemBase.py
22:        self.supportsClang = craftSettings.getboolean("Compile","UseClang", False )
75:        if self.supportsClang:
vonreth edited edge metadata.May 29 2017, 8:28 AM

Does msvc20xx-clang work?
Getting rid of supports clang sounds good but how to build clang on windows then :)

bin/compiler.py
116

I really prefer the

f"{compilerExecutable}"

as I then know what goes where or

"{compilerExecutable}".format(compilerExecutable=compilerExecutable)

{0} is no more verbose than %s

kfunk planned changes to this revision.May 29 2017, 10:14 AM

Does msvc20xx-clang work?

Didn't try.

Getting rid of supports clang sounds good but how to build clang on windows then :)

True. I'll try to come up with a solution for this. I think we should be able to define an 'alternative compiler' or something

This revision was automatically updated to reflect the committed changes.