Handle differences in PAM headers
ClosedPublic

Authored by adridg on May 28 2017, 11:18 AM.

Details

Summary

FreeBSD has neither pam_ext.h nor pam_syslog(), so check for headers
and add defines as appropriate.

Test Plan

Builds on FreeBSD, now. Needs a test-build on Linux.

Diff Detail

Repository
R107 KWallet PAM Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adridg created this revision.May 28 2017, 11:18 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 28 2017, 11:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

See, e.g., https://build-sandbox.kde.org/view/Plasma/job/Plasma kwallet-pam kf5-qt5 FreeBSDQt5.7/1/console

That's the compile failure (pam_kwallet.c:39:10: fatal error: 'security/pam_ext.h' file not found) without these changes.

jriddell accepted this revision.May 31 2017, 9:40 AM

doesn't break the build on Neon

This revision is now accepted and ready to land.May 31 2017, 9:40 AM
This revision was automatically updated to reflect the committed changes.