- Install ccache and compile KStars with:
cmake . -DCCACHE=ON
make -j8
- Clean the files with "make clean"
- Compile again and notice that the object files are taken from the ccache cache instead of recompilation.
Details
Details
- Reviewers
mutlaqja
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Oops. I noticed that I already added ccache support in my previous Android patches. Now I changed the existing version how it should be.
Comment Actions
And the test case in the general description is wrong, it should be:
cmake . -DCCACHE_SUPPORT=ON
make -j8
Comment Actions
Committed in d0bd857d9dfb.
@ckertesz There are many more accepted Diffs for KStars which are still open. Speaking about KDE's Phabricator in general (not sure whether KStars has a different policy?), Diffs should be closed (automatically when using arc land) once accepted and committed.
It's not really urgent, but it would be great if those could be checked whether they are committed indeed, and set to closed eventually. Extra points for including the commit sha. Thanks for making KStars great :)
Comment Actions
Any progress in closing those? Currently they are clogging Phabricator's list of accepted but uncommitted issues not only for KStars but everybody, while yours are probably already committed…
Comment Actions
I don't think you understand? Please look at the list I linked. You are the author, the state is "Accepted". The final state in Phabricator should be "Closed" once the commit has landed in the git repo. Are you saying those commits still have not landed?